test(tbtc/signer): pin concrete coordinator vector in order-independence test#4027
Merged
mswilkison merged 1 commit intoJun 11, 2026
Conversation
The order-independence test asserted only that two input orderings agree, not what they agree on. The Go side now pins the concrete result for the same (members, seed, attempt) tuple, so pin Some(4) here as well to keep the cross-language vector sets symmetric. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
merged commit ac2d5e8
into
extraction/frost-signer-mirror-2026-05-26
19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4005 (base:
extraction/frost-signer-mirror-2026-05-26). Companion to #4026 on the Go branch.What
select_coordinator_is_input_order_independentinpkg/tbtc/signer/src/go_math_rand.rsasserted only that two input orderings of the member set agree — not what they agree on. This pins the concrete result (Some(4)for(members=[1..6], seed=333, attempt=4)), matching the value now pinned on the Go side inTestSelectCoordinator_CrossLanguagePinnedVectors(#4026).Why
Coordinator selection must agree byte-for-byte between Go's
SelectCoordinatorand this Rust port of Go'smath/randshuffle, or honest nodes elect different coordinators and the ROAST liveness path fractures. With the vector sets symmetric across both test suites, either implementation drifting fails its own unit tests instead of surfacing in mixed-version soak testing.Verified locally:
cargo test --lib go_math_randpasses,cargo fmt --checkclean.